Repository navigation
upload: v6 row-bound name from the first write - #14
Merged
Merged
Conversation
The CLI picks the row's UUIDv7 id (clientUploadId) and seals the name to it at create, so no row-unbound v4 name is ever stored, even for an upload that fails before finalize. A server that ignores clientUploadId is refused and its pending row cancelled.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-upload-session already accepts
clientUploadId(UUIDv7) with a v6 name (web #1228,nameEnvelopeFitsRow). The CLI now picks a UUIDv7 row id, seals the name to it at create, and reuses that envelope at finalize, so it never writes a v4 (row-unbound) name. If the server returns a different file id it refuses and cancels that row (existing cancel-on-failure path from #13).Tests: npm test 152/152; new assertions on the create body and a mismatched-id test.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.